Надо экспертное мнение по поводу кода C#

Question

Как можно сделать лучше (в смысле укоротить, или просто более красивым сделать, правильным и т.п.) следующий код: using System; 
 
public class Program 
{ 
    public static void Main(string[] args) 
    { 
        bool firstinputmaybeparsed; 
        bool secondinputmaybeparsed; 
        int firstint; 
        int secondint; 
        string continu; 
        int x=0; 
        int y=0; 
        Console.WriteLine(&#34;Калькулятор двух чисел&#34;); 
        do 
        { 
            do 
            { 
                Console.WriteLine(&#34;Введите первое число...&#34;); 
                string firstinput = Console.ReadLine(); 
                firstinputmaybeparsed = int.TryParse(firstinput, out firstint); 
                if (firstinputmaybeparsed==false) 
                { 
                    Console.WriteLine(&#34;Неверный ввод&#34;); 
                } 
            } while (firstinputmaybeparsed == false); 
 
            do 
            { 
                Console.WriteLine(&#34;Введите второе число...&#34;); 
                string secondinput = Console.ReadLine(); 
                secondinputmaybeparsed = int.TryParse(secondinput, out secondint); 
                if (secondinputmaybeparsed == false) 
                { 
                    Console.WriteLine(&#34;Неверный ввод&#34;); 
                } 
            } while (secondinputmaybeparsed == false); 
 
            bool isoperationvaild = true; 
            do 
            { 
                Console.WriteLine(&#34;Введите операцию: +, -, *, /, %&#34;); 
                string operation = Console.ReadLine(); 
                switch (operation) 
                { 
                    case &#34;+&#34;: 
                        Console.WriteLine(firstint + secondint); 
                        isoperationvaild = true; 
                        break; 
                    case &#34;-&#34;: 
                        Console.WriteLine(firstint - secondint); 
                        isoperationvaild = true; 
                        break; 
                    case &#34;*&#34;: 
                        Console.WriteLine(firstint * secondint); 
                        isoperationvaild = true; 
                        break; 
                    case &#34;/&#34;: 
                        Console.WriteLine(firstint / secondint); 
                        isoperationvaild = true; 
                        break; 
                    case &#34;%&#34;: 
                        Console.WriteLine(firstint % secondint); 
                        isoperationvaild = true; 
                        break; 
                    default: 
                        Console.WriteLine(&#34;Неверный ввод&#34;); 
                        isoperationvaild = false; 
                        break; 
 
                } 
            } while (isoperationvaild != true); 
            do 
            { 
                Console.WriteLine(&#34;Продолжить?&#34;); 
                continu = Console.ReadLine(); 
                switch (continu) 
                { 
                    case &#34;No&#34;: 
                        break; 
                    case &#34;Yes&#34;: 
                        break; 
                    default: 
                        Console.WriteLine(&#34;Неверный ввод&#34;); 
                        isoperationvaild = false; 
                        break; 
                } 
            } while (continu != &#34;Yes&#34; && continu != &#34;No&#34;); 
        } while (continu == &#34;Yes&#34;); 
    } 
}

filya · Answer

using System; 
 
public class Program 
{ 
    public static void Main(string[] args) 
    { 
        Console.WriteLine(&#34;Калькулятор двух чисел&#34;); 
 
        do 
        { 
            int firstInt = GetValidInteger(&#34;Введите первое число...&#34;); 
            int secondInt = GetValidInteger(&#34;Введите второе число...&#34;); 
 
            string operation = GetValidOperation(); 
 
            PerformOperation(firstInt, secondInt, operation); 
 
        } while (GetContinueResponse() == &#34;Yes&#34;); 
    } 
 
    private static int GetValidInteger(string prompt) 
    { 
        int result; 
        string input; 
        do 
        { 
            Console.WriteLine(prompt); 
            input = Console.ReadLine(); 
        } while (!int.TryParse(input, out result)); 
 
        return result; 
    } 
 
    private static string GetValidOperation() 
    { 
        string operation; 
        do 
        { 
            Console.WriteLine(&#34;Введите операцию: +, -, *, /, %&#34;); 
            operation = Console.ReadLine(); 
        } while (operation != &#34;+&#34; && operation != &#34;-&#34; && operation != &#34;*&#34; && operation != &#34;/&#34; && operation != &#34;%&#34;); 
 
        return operation; 
    } 
 
    private static void PerformOperation(int firstInt, int secondInt, string operation) 
    { 
        switch (operation) 
        { 
            case &#34;+&#34;: 
                Console.WriteLine(firstInt + secondInt); 
                break; 
            case &#34;-&#34;: 
                Console.WriteLine(firstInt - secondInt); 
                break; 
            case &#34;*&#34;: 
                Console.WriteLine(firstInt * secondInt); 
                break; 
            case &#34;/&#34;: 
                if (secondInt == 0) 
                    Console.WriteLine(&#34;Деление на ноль невозможно.&#34;); 
                else 
                    Console.WriteLine(firstInt / secondInt); 
                break; 
            case &#34;%&#34;: 
                Console.WriteLine(firstInt % secondInt); 
                break; 
        } 
    } 
 
    private static string GetContinueResponse() 
    { 
        string response; 
        do 
        { 
            Console.WriteLine(&#34;Продолжить? (Yes/No)&#34;); 
            response = Console.ReadLine(); 
        } while (response != &#34;Yes&#34; && response != &#34;No&#34;); 
 
        return response; 
    } 
}

Jurijus Zaksas · Answer

Примерно так (это для плавающей точки, переделай под свои целые числа если очень приспичило):

static double GetDouble(string _Prompt) 
{ 
    int t = 0; 
    double Result; 
    do 
    { 
        if (t++ > 0) 
            Console.WriteLine(&#34;Error parsing input&#34;); 
        Console.Write(_Prompt); 
    } 
    while (!double.TryParse(Console.ReadLine(), out Result)); 
    return Result; 
} 
 
static char GetChar(string _Prompt, string _Filter) 
{ 
    int t = 0; 
    char Result; 
    do 
    { 
        if (t++ > 0) 
            Console.WriteLine(&#34;Invalid input, please enter one of the following: &#34; + _Filter); 
        Console.Write(_Prompt); 
        Result = Console.ReadKey().KeyChar; 
        Console.WriteLine(); 
    } 
    while (!_Filter.Contains(Result)); 
    return Result; 
} 
 
private delegate double MathOperation(double x, double y); 
private static double Add(double x, double y) => x + y; 
private static double Subtract(double x, double y) => x - y; 
private static double Multiply(double x, double y) => x * y; 
private static double Divide(double x, double y) => x / y; 
 
private static MathOperation CharToOp(char c) 
{ 
    switch(c) 
    { 
        case '-': return Subtract;  
        case '+': return Add; 
        case '*': return Multiply; 
        case '/': return Divide;                 
    } 
    return null; 
} 
 
static void Main(string[] args) 
{ 
    Console.WriteLine(&#34;A primitive calculator, press Cntrl-C to exit anytime&#34;); 
    do 
    { 
        double x = GetDouble(&#34;Enter first number: &#34;); 
        double y = GetDouble(&#34;Enter second number: &#34;); 
        char OpChar = GetChar(&#34;Enter operation symbol: &#34;, &#34;/*-+&#34;); 
        MathOperation op = CharToOp(OpChar); 
        Console.WriteLine($&#34;{x}{OpChar}{y}={op(x, y)}&#34;); 
    } 
    while (true); 
}